Initial touch controls implementation #1160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyakoFox
force-pushed
the
touch-initial
branch
2 times, most recently
from
6f47455 to
adff529
Compare
NyakoFox
force-pushed
the
touch-initial
branch
from
adff529 to
db611bd
Compare
NyakoFox
force-pushed
the
touch-initial
branch
from
db611bd to
ee1efa5
Compare
|
I've rebased and pushed -- do note that I don't have any apple devices so I'm unable to test for iOS. |
leo60228
suggested changes
Nov 21, 2024
This commit adds virtual buttons on-screen to let you navigate through menus, and play the game.
Touch input automatically "disables" when you press a key on your keyboard. The back button on Android counts as a key press, so let's just ignore it.
For some reason, the code that handled button presses for the ingame menu checked the confirm button in the wrong places.
NyakoFox
force-pushed
the
touch-initial
branch
from
ee1efa5 to
6ed3fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds touch controls to the game. While not being the prettiest UI-wise, it makes it possible to play the game using touch controls, making testing on mobile devices much easier. This PR will be followed up by other PRs which implement more features, such as:
Supersedes #1142.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement