Add support for GameCube glyphs #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's kind of a bummer that L/R don't actually do anything... we should add ZL/ZR support at some point. Also note that GameCube binds X to 'back' rather than B, this will be fixed by SDL_ActionSet for 2.5.
InfoTeddy
added
the
localization
|
I can't test with a GameCube controller myself so I can't verify the layout, but the font and code changes look correct to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kind of a bummer that L/R don't actually do anything... we should add ZL/ZR support at some point, my fault for not handling the trigger axes properly.
Also note that GameCube binds X to 'back' rather than B, this will be fixed by SDL_ActionSet for 2.5.
CC @Fussmatte @Daaaav, in case I got the font data wrong!
Fixes #1116