Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent map issues #775

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix parent map issues #775

merged 1 commit into from
Sep 15, 2024

Conversation

mt1006
Copy link
Contributor

@mt1006 mt1006 commented Sep 6, 2024 •
edited
Loading

This PR fixes two main issues with current parent map:

  • Mod whose parent also has a parent doesn't show up. Now if A has parent B, and B has parent C, then C will be treated as parent of both A and B.
  • If two or more mods declare each other as parents, then none of them is visible and trying to search for mods may crash the game (it's probably the case in Crash when search mods #763). Now in such case all of these mods will be treated as root mods.

@Prospector Prospector merged commit e9d838c into TerraformersMC:1.21 Sep 15, 2024
1 check passed
@Prospector
Copy link
Member

Thanks! looks great

gniftygnome pushed a commit to gniftygnome/ModMenu that referenced this pull request Oct 8, 2024
@mt1006 @gniftygnome
Fix parent map issues (TerraformersMC#775)
712fc21
Prospector pushed a commit that referenced this pull request Oct 14, 2024
@mt1006 @Prospector
Fix parent map issues (#775)
8f0b1ed 
- Fixed issues with parent mods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mt1006 @Prospector