Replay concurrency fixes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasantakumar82
requested review from
chrisdennis,
jhouserizer,
cljohnso and
devlg75
|
@prasantakumar82 Can you briefly describe the need for this change? |
|
be careful with this one. We found some pathological cases years ago where anything other than 1 thread for replay concurrency led to very slow recovery due to thread contention. It's been a long time but I think I am reading this PR correctly. |
…ng same concurrency value will be replayed sequentially. Setting the default value to -1, so implementation class can implement own concurrency strategy and return correct concurrency value.
prasantakumar82
force-pushed
the
replay-concurrency
branch
from
02de26a
to
eab9d21
Compare
Thanks for the information. Thread contention issue in sovereign layer is fixed also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.