Add com.teradata.git.hash to image labels #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see the removal of 'pushing a second tag'. I assume docker-release does this? I think those tags and labels won't conflict (they're different entities), but just wanted to make sure removing the tag pushing is not needed :) |
|
LGTM :) |
|
Just a thought: maybe fix #2 in the same shot? :) |
|
Yeah, I'm opening the PR for not pushing the second tag now against docker-release. Tags and labels are non-conflicting. Labels are metadata contained within the image itself, and can only be set at build time. Tags are a pointer to an image ID. |
|
I'll do the microbadger stuff (#2) in another PR sometime next week, but thanks for pointing that one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better way of adding a git hash than pushing a second tag to dockerhub.