Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for controlling screen on and off #7

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

jflaflamme
Copy link
Contributor

No description provided.

Copy link
Owner

@Tenzer Tenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I think I would prefer to add alga power screen-off and alga power screen-on commands rather than adding another top-level command.

There are some checks in CI which will need fixing. Let me know if you'd like some help with those after you have moved the commands over to cli_power.py.

@jflaflamme
Copy link
Contributor Author

Thank you for the suggestion, I was hesitating to put under power vs a new sub-menu.
Pushed a new commit.

@Tenzer
Copy link
Owner

Tenzer commented Jun 19, 2024

Looks good now, thank you!

@Tenzer Tenzer merged commit 3b5c444 into Tenzer:main Jun 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants