DONE: Migrate the westore project to TypeScript #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChelesteWang
changed the title
|
后续任务： |
|
@dntzhang 抽空 review 一下 |
ChelesteWang
commented
Sep 27, 2021
packages/westore/src/westore.ts
Outdated
| if (current === previous) return | ||
|
|
||
| const rootCurrentType: DataTypes = getType(current) | ||
| const rootPreType: DataTypes = getType(previous) | ||
|
|
||
| if (rootCurrentType == OBJECTTYPE && rootPreType == OBJECTTYPE) { | ||
| for (const key in previous) { |
There was a problem hiding this comment.
主要问题在于 eslint 由于类型系统读取不到 auto fix 的时候优化成了常量
packages/westore/src/westore.ts
Outdated
| path: string, | ||
| result: any | ||
| ) { | ||
| function _diff(current: any, previous: any, path: string, result: any) { |
There was a problem hiding this comment.
先暂时用 any 类型后面进行优化
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.js 产物已可在 example 小程序上运行