Without "set -e" the job will always be successful. see vmactions/fre…

…ebsd-vm#72 for details
Tencent · Sep 29, 2024 · 3dca8b3 · 3dca8b3
1 parent e92cba2
commit 3dca8b3
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -109,12 +109,9 @@ jobs:
 
       - name: Build for Debian
         run: |
-            while :; do echo "Still compiling..."; sleep 60; done &  
-            PERIODIC_OUTPUT_PID=$! 
             cd build/test/linux  
             chmod +x *.sh
             ./RunTest_GCC.sh 
-            kill $PERIODIC_OUTPUT_PID
   
   build_debian_test_and_run_Clang:
     runs-on: ubuntu-latest
@@ -140,12 +137,9 @@ jobs:
 
       - name: Build for Debian
         run: |
-            while :; do echo "Still compiling..."; sleep 60; done & 
-            PERIODIC_OUTPUT_PID=$! 
             cd build/test/linux  
             chmod +x *.sh
             ./RunTest_Clang.sh 
-            kill $PERIODIC_OUTPUT_PID
 
 
   #Mac
@@ -186,17 +180,15 @@ jobs:
             pkg install -y gcc cmake bash openjdk11
 
           run: |
+            set -e -x
             pkg info -l openjdk11 | grep 'bin/java'
             export JAVA_HOME="/usr/local/openjdk11"
             export PATH="$JAVA_HOME/bin:$PATH"
             echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV
             echo "PATH=$PATH" >> $GITHUB_ENV
             cd build/test/unix_like  
             chmod +x *.sh
-            while :; do echo "Still compiling..."; sleep 60; done &  
-            PERIODIC_OUTPUT_PID=$! 
             ./RunTest_GCC.sh 
-            kill $PERIODIC_OUTPUT_PID
   
   build_freeBSD_test_and_run_Clang:
     runs-on: ubuntu-latest
@@ -213,14 +205,12 @@ jobs:
             pkg install -y gcc cmake bash openjdk11
 
           run: |
+            set -e -x
             pkg info -l openjdk11 | grep 'bin/java'
             export JAVA_HOME="/usr/local/openjdk11"
             export PATH="$JAVA_HOME/bin:$PATH"
             echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV
             echo "PATH=$PATH" >> $GITHUB_ENV
             cd build/test/unix_like  
             chmod +x *.sh
-            while :; do echo "Still compiling..."; sleep 60; done &  
-            PERIODIC_OUTPUT_PID=$! 
             ./RunTest_Clang.sh 
-            kill $PERIODIC_OUTPUT_PID