Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-10753 Fix background #412

Merged
merged 2 commits into from
Nov 21, 2024
Merged

IOS-10753 Fix background #412

merged 2 commits into from
Nov 21, 2024

Conversation

amegias
Copy link
Contributor

@amegias amegias commented Nov 19, 2024

Warning

Should a designer need to review/verify this PR?

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-10753

🥅 What's the goal?

wrong background in SwiftUI catalog when it's dark mode and shows inverse links.
swiftui

🚧 How do we do it?

It's already solved in the UIKit catalog, so I've taken the same background colors.

🧪 How can I verify this?

Dark

Captura de pantalla 2024-11-20 a las 12 37 37

Light

Captura de pantalla 2024-11-20 a las 12 37 42

@amegias amegias marked this pull request as ready for review November 19, 2024 10:45
@amegias amegias merged commit c7af167 into main Nov 21, 2024
2 checks passed
@amegias amegias deleted the IOS-10753-fix-catalog-background branch November 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants