IOS-10545 Update Makefile with XCode 16 #402
Conversation
alejandroruizponce
changed the title
alejandroruizponce
force-pushed
the
IOS-10545-Update-Makefile-to-XCode-16
branch
from
a7b72c0
to
38a1773
Compare
|
Record screenshots on PR comment: succeeded ✅ |
There was a problem hiding this comment.
it's weird but if you notice the new circle is painted worse than the old one. The old one has an “anti aliasing” effect and the new one has sawtooths in some areas.
There was a problem hiding this comment.
Yes, this is something that happens with XCode 16... I have seen in the snapshot testing repo that there are people with the same problem and it is not clear what the solution is... I have tried several things but I think I will have to wait for a future version of snapshot to fix this bug.
There was a problem hiding this comment.
the same in this case, the circle is not pixel perfect
alejandroruizponce
requested review from
a team and
marinitx
and removed request for
a team
|
🎉 This PR is included in version 33.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10545
🥅 What's the goal?
Build and integrate with XCode 16 and iOS 18 now we have slaves updated with that version.
🚧 How do we do it?
Update configuration in Makefile with a new simulator iPhone 16 in iOS 18.0 and using XCode 16 app.
Compiling with XCode 16 and on iPhone 16 misaligns some tiny pixels in the snapshots which requires that many of them have been re-generated with very little difference.
🧪 How can I verify this?
There are many tests that have been updated probably due to variations of 1px or less, this is something that already happened with iOS 17 back in the day, I recommend checking them from Sourcetree or similar as the Github page will freeze trying to load so many snapshots.
For Design review: A release for Mistica Catalog has been generated in Alpha Mistica-SwiftUI-iOS app center project.