IOS-9433 [iOS]Mistica Implementing the Small style in the Header component #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Header-component * main: chore(XCode15): Update Makefile for XCode 15 building
|
Screenshot tests report ✔️ All passing |
…ponent' of https://github.com/Telefonica/mistica-ios into IOS-9433-Implementing-the-Small-style-in-the-Header-component * 'IOS-9433-Implementing-the-Small-style-in-the-Header-component' of https://github.com/Telefonica/mistica-ios: Run swiftformat
There was a problem hiding this comment.
There was a problem hiding this comment.
DavidMarinCalleja
requested review from
dhidalgofadrique,
MontseTelefonica and
WanaldinoTelefonica
MontseTelefonica
approved these changes
Oct 23, 2023
|
|
||
| show(vc, sender: self) | ||
| } | ||
| } | ||
|
|
||
| private extension UICatalogHeaderViewController { | ||
| func createSegmentedControl(reuseIdentifier: String, firstSegmentedTitle: String, secondSegmentedTitle: String) -> UISegmentedControlTableViewCell { | ||
| func createSegmentedControl(reuseIdentifier: String, segments: String...) -> UISegmentedControlTableViewCell { |
DavidMarinCalleja
deleted the
IOS-9433-Implementing-the-Small-style-in-the-Header-component
branch
|
🎉 This PR is included in version 26.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9433 [iOS]Mistica Implementing the Small style in the Header component
🥅 What's the goal?
A new style called Small has been added to the Header component.
Header Components Specs
🚧 How do we do it?
I've added two new styles to HeaderViewStyle.swift
🧪 How can I verify this?
🏑 AppCenter build
You can use the alpha build https://install.appcenter.ms/orgs/Tuenti-Organization/apps/Mistica-SwiftUI-iOS
