iOS-8994 feed back evolution #303
Conversation
WanaldinoTelefonica
requested review from
aweell,
DavidMarinCalleja and
alejandroruizponce
and removed request for
a team
Yes, thats right! Non animated images didn't resize into 48px correctly. Thanks! What do you mean that latter content is not animated? If you refer to info style, specs only define that succes and error should. |
Sorry, not explicit enough with "latter" I was talking about the feedback style variant. The current web implementation was showing the animation but is because is being used as a base component for the other variants and the animation is configurable via prop. Forget about this :) |
| if title.isEmpty == false { | ||
| views.append(titleLabel) | ||
| } | ||
| if let subtitle, subtitle.isEmpty == false { | ||
| views.append(subtitleLabel) | ||
| } | ||
| if let errorReference, errorReference.isEmpty == false { | ||
| views.append(errorReferenceLabel) | ||
| } |
There was a problem hiding this comment.
This can be simplified by using the ! operator
| if title.isEmpty == false { | |
| views.append(titleLabel) | |
| } | |
| if let subtitle, subtitle.isEmpty == false { | |
| views.append(subtitleLabel) | |
| } | |
| if let errorReference, errorReference.isEmpty == false { | |
| views.append(errorReferenceLabel) | |
| } | |
| if !title.isEmpty { | |
| views.append(titleLabel) | |
| } | |
| if let subtitle, !subtitle.isEmpty { | |
| views.append(subtitleLabel) | |
| } | |
| if let errorReference, !errorReference.isEmpty { | |
| views.append(errorReferenceLabel) | |
| } |
There was a problem hiding this comment.
I'm not a big fan of inverting booleans as I consider it is less readable.
There was a problem hiding this comment.
In this case, Is this going to change the Viviño icon to Tick icon?
There was a problem hiding this comment.
Yes, only for success feedback screen
WanaldinoTelefonica
requested review from
idenjoe
and removed request for
alejandroruizponce
New asset provided: https://jira.tid.es/secure/attachment/2166789/f_feedback%20icon%20v3.json |
|
Hi @aweell! A new version has been upload with the new json file. Thanks 😄 |
|
🎉 This PR is included in version 26.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎟️ Jira ticket
IOS-8994
🥅 What's the goal?
🚧 How do we do it?
🧪 How can I verify this?
Grabacion.de.pantalla.2023-09-12.a.las.10.51.10.mov
🏑 AppCenter build