IOS-9281 weird rounded border #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amegias
force-pushed
the
IOS-9282-weird-rounded-border
branch
from
545b372
to
c3b737c
Compare
amegias
commented
Aug 30, 2023
| @@ -278,7 +278,6 @@ private extension Button { | |||
| } | |||
|
|
|||
| func setUpView() { | |||
| layer.cornerCurve = .continuous | |||
There was a problem hiding this comment.
circular by default => it fixes the issue 🥳
amegias
commented
Aug 30, 2023
| @@ -35,33 +35,33 @@ private struct CornerRadiusModifier: ViewModifier { | |||
| .overlay(Capsule().stroke(borderColor, lineWidth: lineWidth)) | |||
| case .button: | |||
| content | |||
| .clipShape(RoundedRectangle(cornerRadius: MisticaConfig.currentCornerRadius.button, style: .continuous)) | |||
| .overlay(RoundedRectangle(cornerRadius: MisticaConfig.currentCornerRadius.button, style: .continuous).stroke(borderColor, lineWidth: lineWidth)) | |||
| .clipShape(RoundedRectangle(cornerRadius: MisticaConfig.currentCornerRadius.button)) | |||
There was a problem hiding this comment.
circular by default => it fixes the issue 🥳
amegias
requested review from
yceballost,
alejandroruizponce and
WanaldinoTelefonica
|
it fixes the issue with the snapshots (tests) but the buttons look worse in prod: before (smooth)
after
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-9281
🥅 What's the goal?
Fix this:
🚧 How do we do it?
I've just changed
.continuousto.circular: 23333c6PLEASE REVIEW IT COMMIT BY COMMIT:
🧪 How can I verify this?
🏑 AppCenter build
@yceballost could you help us validate the corner radius on the buttons?? especially in Vivo-New
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public/releases/25