Fix missing #![feature(generic_const_exprs)] in doctests
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tehforsch
force-pushed
the
fix-ice-133199
branch
2 times, most recently
from
47c6bae to
21da7c3
Compare
Some of them were missing this feature annotation but used to compile and pass for some inexplicable reason. Now this missing feature gate causes an ICE (rust-lang/rust#133199). This adds the feature gates in all the doctests, but does not yet address the fact that this ICE also occurs in calling crates that don't have `#![feature(generic_const_exprs)]` set. Maybe a workaround could be to check for this feature explicitly and throw a helpful error message in diman.
Tehforsch
force-pushed
the
fix-ice-133199
branch
from
21da7c3 to
6f1763e
Compare
|
|
|
Thanks for noticing, after updating to the latest nightly, I also see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #86 occuring in some of the doctests