Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #25
This adds the
rational-dimensions
feature to use rational dimensions instead of just integer dimensions. Comes along with some minor code cleanups. I added my own very unsophisticatedRatio
type in order not to pull in an additional dependency.Todo:
add documentation for the feature
write better tests (ideally with a useful example)
think about how to improve compiler error messages. Probably rewriting the
Ratio
struct to a tuple struct with two entries will already improve things.add tests to CI
Allow definitions to make use of the rational dimensions so we can write
dimension SqrtLength = Length^(1/2)