Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where E438 won't evaluate correctly #39

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix bug where E438 won't evaluate correctly #39

merged 1 commit into from
Jul 11, 2024

Conversation

Teester
Copy link
Owner

@Teester Teester commented Jul 11, 2024

Necessity was calculated incorrectly when a shape had only 1 expression as there was no expressions key in the shape, just a single expression key. This takes that into account.

Also added a test for this issue

@Teester Teester self-assigned this Jul 11, 2024
@Teester Teester added bug Something isn't working backend Issues relating to the python backend labels Jul 11, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (0d13754) to head (4b74794).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   90.08%   90.17%   +0.09%     
==========================================
  Files           6        6              
  Lines         958      967       +9     
==========================================
+ Hits          863      872       +9     
  Misses         95       95              
Files Coverage Δ
comparejsonld.py 96.53% <100.00%> (+0.07%) ⬆️
test_schemas.py 98.47% <100.00%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d13754...4b74794. Read the comment docs.

@Teester Teester merged commit 5c4484f into master Jul 11, 2024
6 of 7 checks passed
@Teester Teester deleted the Fix-E438 branch July 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues relating to the python backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant