Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt a dog survey #436

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adopt a dog survey #436

wants to merge 4 commits into from

Conversation

cecavi
Copy link

@cecavi cecavi commented Mar 19, 2023

So this project is almost finished. I still need to finish the last basic requirement.

  • Your site should follow accessibility guidelines
  • I also like to style it more

Copy link

@YlvaKarlsson YlvaKarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Cecilia! You should be proud of your knowledge so far and great job with this survey.
I'm sorry for the delayed code review due to sickness this week as well. I hope it didn't cause you some problems.

Keep up the good work and let's learn coding together for many more weeks :D

Replace this readme with your own information about your project.

Start by briefly describing the assignment in a sentence or two. Keep it short and to the point.
So this is an unfinished project. I still need to style it and make it more accesible. i focused on getting the react code and components to work.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think you made a good job by making it work in such a nice way!

@@ -13,7 +13,7 @@
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>Technigo React App</title>
<title>Adopt a dog survey</title>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see that you changed the title, many people miss this one :)

@@ -0,0 +1,21 @@
import React from 'react'

const sizes = ['XS', 'S', 'M', 'L', 'XL']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with adding the different sizes in an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants