Add window reload to startOver() function
#25
Conversation
src/app/page.tsx
Outdated
| // TODO: Fix if possible. This is a hack to ensure that image generated is as expected. Without repeating generateImage(), at times, the image wont be generated correctly. | ||
| await generateImage() | ||
| await generateImage() | ||
| await generateImage() |
There was a problem hiding this comment.
were you able to test this on a mobile device?
There was a problem hiding this comment.
I haven't tested this on a mobile device unfortunately. It works when I use the mobile simulator in DevTools on Chrome (and Chromium). Is that ok? If not, are there other ways that you normally test the PRs in this repo?
There was a problem hiding this comment.
Let me test it on the phone tonight
they way I would test is that after running the app on my local machine, I can then connect my phone to the same network as my machine, and use the local IP assigned by my router to my machine in the phone, i.e. my current local IP is:
I will connect to the same network and visit http://192.168.18.15:3000 then I will be able to visit this site on my phone
There was a problem hiding this comment.
Sorry the issue still exists on the mobile phone
There was a problem hiding this comment.
That's weird. I just set up ngrok and tried testing this branch in Chrome for Android as well as Firefox Focus and Brave: it was a little slow to load for me but I was able to save the different profile pictures just fine. Are you using an iPhone by any chance?
There was a problem hiding this comment.
The issue is not with that, that PR of yours was I believe merged last week, where a user couldn't re use a different image.
This one relates to multiple await to download an image
There was a problem hiding this comment.
Oh, they have merged the wrong one
Keep the multiple awaits, we can fix it in another PR, just have the windows.reload feature to start over
There was a problem hiding this comment.
yes, let's create a new PR for resolving the multiple reloads
There was a problem hiding this comment.
I've just pushed a version of the commit with the multiple awaits re-added.
Twitter and Github profiles work but now all of a sudden I can't get Gitlab profile pictures to download. Seems to be a CORS issue. It's very strange because I was sure it worked last week and I don't think any of the changes made recently would explain this. Does it still work for you? If not, I might need to raise another issue 😕
kohrVid
force-pushed
the
fix-image-not-changing
branch
from
4441ad1 to
84b2e08
Compare
This removes the need for the repeated calls to `generateImage()` when profile pictures are downloaded.
kohrVid
force-pushed
the
fix-image-not-changing
branch
from
84b2e08 to
6f96671
Compare
This should fix #22, removing the need for the repeated calls to
generateImage()when profile pictures are downloaded.