Recenter yaml files around brands instead of companies #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alternative_brands. Add schema validation
idris
force-pushed
the
unify-brands
branch
2 times, most recently
from
657c1b0 to
26f0ce5
Compare
THM222
approved these changes
Jan 7, 2024
| print('Validating', len(company_files), 'companies') | ||
| for file in company_files: | ||
| if not validate_with_schema(file, company_schema): | ||
| exit(1) |
There was a problem hiding this comment.
Instead of exitting on first failure, i think it'd be good to check and log messages for all failures, then exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brands are now top-level and the most important entity.
Companies are a secondary entity, which you can link brands to if it's useful/relevant.
Added a
statusenum to brands and companies, to decide whether they are neutral, brands to support, or brands to avoid.Thus, there is no difference between an alternative brand and a brand, other than the status. This also allows brands to transition from "avoid" to "neutral" or "support", if they cease harmful activities.
Also added a schema, with validation (#4), to ensure that all yaml files match the schema.