Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include test metadata in the results.json file #5336

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Include test metadata in the results.json file #5336

merged 2 commits into from
Dec 22, 2019

Conversation

smathews-techempower
Copy link
Contributor

Handles #2 in TechEmpower/tfb-status#19

  • break up the jsonable logic for Metadata to its own function
  • use this jsonable function when generating results.json

@smathews-techempower
Include metadata in results.json file:
496deb1 
- break up the jsonable logic for Metadata to its own function
- use this jsonable function when generating results.json
@NateBrady23 NateBrady23 merged commit 16050cf into TechEmpower:master Dec 22, 2019
@smathews-techempower smathews-techempower mentioned this pull request Jan 21, 2020
Merged
tomciopp pushed a commit to tomciopp/FrameworkBenchmarks that referenced this pull request Oct 21, 2020
@smathews-techempower @tomciopp
Include test metadata in the results.json file (TechEmpower#5336)
ef4a27a 
* Include metadata in results.json file:
- break up the jsonable logic for Metadata to its own function
- use this jsonable function when generating results.json

* Store test metadata array under the test_metadata key for consistency and clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmith-techempower msmith-techempower msmith-techempower approved these changes

@NateBrady23 NateBrady23 NateBrady23 approved these changes

@michaelhixson michaelhixson michaelhixson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smathews-techempower @michaelhixson @NateBrady23 @msmith-techempower