fix: Allow custom RPC URL in FeeService class #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NerdMuckee is attempting to deploy a commit to the wowcats Team on Vercel. A member of the Team first needs to authorize it. |
muckee
changed the title
|
Just thought to mention... I decided to forward the connection as a separate parameter, instead of adding it to the payload described by I assumed that your intended definition of 'payload' describes data included in the blockchain interaction, as opposed to all of the data passed as props within JS. Let me know if you want me to edit the PR so that the connection is passed as one of the properties of GetOptimalComputeUnitLimitAndPricePayload, instead of as a separate parameter. |
Mideee419
approved these changes
Dec 31, 2024
| @@ -100,7 +102,7 @@ class FeeServiceImpl implements FeeService { | |||
| }).compileToV0Message(lookupTables), | |||
| ); | |||
|
|
|||
| const simulation = await this.connection.simulateTransaction( | |||
| const simulation = await (connection || this.connection).simulateTransaction( | |||
czsko707
reviewed
Jan 18, 2025
| @@ -100,7 +102,7 @@ class FeeServiceImpl implements FeeService { | |||
| }).compileToV0Message(lookupTables), | |||
| ); | |||
|
|
|||
| const simulation = await this.connection.simulateTransaction( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code uses the
RPC_URLconstant defined in theconstant.tsfile to instantiate a new web3 connection.With these changes, a
Connectioncan be optionally passed to thegetOptimalComputeUnitLimitAndPricefunction, which is used to override the connection defined in the constructor of the FeeService class whenConnection.simulateTransactionis executed.Additionally, inside the referral.ts file, the referral provider's connection property is passed to
feeService.getOptimalComputeUnitLimitAndPriceto ensure that the fee service can make use of custom RPC URLs passed to the provider.