-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/admob_reward_video]: 리워드 비디오 광고 작업 #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
requested changes
Oct 16, 2023
app/src/main/java/com/teampophory/pophory/feature/album/cover/AlbumCoverEditActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/config/ad/AdmobRewardedAdService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/album/cover/AlbumCoverEditActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/home/store/StoreFragment.kt
Outdated
Show resolved
Hide resolved
domain/ad/src/main/java/com/teampophory/pophory/ad/entity/AdConstant.kt
Outdated
Show resolved
Hide resolved
domain/ad/src/main/java/com/teampophory/pophory/ad/entity/AdConstant.kt
Outdated
Show resolved
Hide resolved
l2hyunwoo
approved these changes
Oct 17, 2023
app/src/main/java/com/teampophory/pophory/config/ad/AdmobRewardedAdService.kt
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/album/cover/AlbumCoverEditActivity.kt
Show resolved
Hide resolved
domain/ad/src/main/java/com/teampophory/pophory/ad/entity/AdIdentifier.kt
Show resolved
Hide resolved
data/ad/src/main/java/com/teampophory/pophory/ad/model/AdConstantResponse.kt
Outdated
Show resolved
Hide resolved
data/ad/src/main/java/com/teampophory/pophory/ad/model/AdConstantResponse.kt
Outdated
Show resolved
Hide resolved
librarywon
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의진이 수고했서 시험끝나고 더 자세히 볼 수 있어서 그 때 물어볼게오
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드
🍀 관련 이슈
현재 버전인 1.1.4 에서 광고 리스트가 내려오지 않는 이슈가 있어서 테스트는 아직 해보지 못했습니다.