Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamin0422
reviewed
Oct 18, 2023
| binding.viewpagerButton.setTextColor(ContextCompat.getColor(requireContext(), R.color.white)) | ||
| } else { | ||
| binding.viewpagerButton.setTextColor(ContextCompat.getColor(requireContext(), R.color.grey_909090)) | ||
| } |
There was a problem hiding this comment.
biding이 공통적으로 사용되는 거 같아 보이는데, with(binding)을 사용해 중복되는 단어를 줄여보는 건 어떤가요?? 각 View들의 속성을 설정하는 부분을 따로 메서드로 생성해 가독성을 높이는 것도 좋아 보이네요.
fun setViewPagerButton(nickname: string) {
with (binding.viewpagerButton) {
isEnabled = nickname.isNotEmpty()
if (isEnabled) {
setTextColor(ContextCompat.getColor(requireContext(), R.color.white))
} else {
setTextColor(ContextCompat.getColor(requireContext(), R.color.grey_909090))
}
}
}
| <variable | ||
| name="vm" | ||
| type="com.owori.android.auth.ui.viewmodel.NickNameViewModel" /> | ||
| </data> |
There was a problem hiding this comment.
variable이 NickNameViewModel이군요. 해당 fragment는 NickNameViewModel과 연관이 없는 듯 하니 관련 없는 코드는 삭제 부탁드립니다.
| <variable | ||
| name="vm" | ||
| type="com.owori.android.auth.ui.viewmodel.NickNameViewModel" /> | ||
| </data> |
There was a problem hiding this comment.
마찬가지입니다~
variable이 NickNameViewModel이군요. 해당 fragment는 NickNameViewModel과 연관이 없는 듯 하니 관련 없는 코드는 삭제 부탁드립니다.
|
|
||
| <variable | ||
| name="vm" | ||
| type="com.owori.android.auth.ui.viewmodel.NickNameViewModel" /> |
There was a problem hiding this comment.
이것도요~
variable이 NickNameViewModel이군요. 해당 fragment는 NickNameViewModel과 연관이 없는 듯 하니 관련 없는 코드는 삭제 부탁드립니다.
| android:layout_height="wrap_content" | ||
| android:textAppearance="@style/TextBodyRegular.03" | ||
| android:textColor="@color/black" | ||
| app:layout_constraintBottom_toBottomOf="@id/nickname_et" |
There was a problem hiding this comment.
nickname_length의 color 변경이 필요해보입니다.
|
수정 확인 후, conflict resolved 되었을 때, approve 처리하겠습니다~🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧨이슈
🔍 상세 내용 (해결 내용)
💡 참고자료 및 공유할만한 자료 (선택)
❕후속 진행 이슈