-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.21.13 #7268
Release/0.21.13 #7268
Conversation
62642e8
to
b79ea7b
Compare
I went through #6872 again for half an hour and did not understand the changes and why some of them were made. I'd suggest to revert that PR to fully fix resuming the streams. I think it is better do re-do that feature as my current fix is incomplete. Pressing the "background" button while a video is playing does not resume the stream, but still starts at the beginning. |
Yes, #6872 should be reverted and can then be made again without the removal of the resumePlayback parameter in the NavigationUtil class' methods |
For the issue with the version check I wonder if it could be tried in onPostCreate https://developer.android.com/reference/android/app/Activity#onPostCreate(android.os.Bundle) |
f82df7d
to
dc4cd56
Compare
dc4cd56
to
768bb0b
Compare
@Redirion That's a better solution. Thanks. |
What is it?
Description of the changes in your PR
onCreate()
toonResume()
. A variable has been added toApp
to ensure that the service is not executed every timeonResume()
is called.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence