Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.21.13 #7268

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Release/0.21.13 #7268

merged 6 commits into from
Oct 21, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Oct 17, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixed resuming playback. Streams were always starting at the beginning before; a regression from Added a play next button to the long press menu #6872
  • Fixed service for new version check is still occasionally started in background. Starting the service is moved from onCreate() to onResume(). A variable has been added to App to ensure that the service is not executed every time onResume() is called.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TobiGr
Copy link
Contributor Author

TobiGr commented Oct 18, 2021

I went through #6872 again for half an hour and did not understand the changes and why some of them were made. I'd suggest to revert that PR to fully fix resuming the streams. I think it is better do re-do that feature as my current fix is incomplete. Pressing the "background" button while a video is playing does not resume the stream, but still starts at the beginning.

@Redirion
Copy link
Member

Yes, #6872 should be reverted and can then be made again without the removal of the resumePlayback parameter in the NavigationUtil class' methods

@Redirion
Copy link
Member

For the issue with the version check I wonder if it could be tried in onPostCreate https://developer.android.com/reference/android/app/Activity#onPostCreate(android.os.Bundle)

@TobiGr
Copy link
Contributor Author

TobiGr commented Oct 20, 2021

@Redirion That's a better solution. Thanks.

@TobiGr TobiGr merged commit 44cad27 into dev Oct 21, 2021
@TobiGr TobiGr deleted the release/0.21.13 branch October 21, 2021 18:51
@TobiGr TobiGr restored the release/0.21.13 branch October 21, 2021 18:52
@TobiGr TobiGr deleted the release/0.21.13 branch October 21, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resume Playback is not working
3 participants