-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(accident - ignore) Release/0.21.10 #7117
Conversation
…minimized player in VideoDetailFragment The comments tab was updated although the settings for the description tab were changed.
…server() Hopefully also fix the cause of the original error.
* Using [``process-phoenix``](https://github.com/JakeWharton/ProcessPhoenix)
Just like in the issue 7062, #7062, this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
Change player progress bar update from 500 ms to 1 s
Fixed the navbar color for darkmode
Fix handling exception in `playOnPopup` and toggle description tab
Fixed restarting not working properly
Currently translated at 56.1% (32 of 57 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Vietnamese) Currently translated at 99.8% (618 of 619 strings) Translated using Weblate (Polish) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Japanese) Currently translated at 99.5% (616 of 619 strings) Translated using Weblate (Ukrainian) Currently translated at 77.1% (44 of 57 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Sardinian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Galician) Currently translated at 94.9% (588 of 619 strings) Translated using Weblate (Lithuanian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Hebrew) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Persian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Slovak) Currently translated at 96.2% (596 of 619 strings) Translated using Weblate (Greek) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Italian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (French) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (German) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Russian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (English) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Polish) Currently translated at 52.6% (30 of 57 strings) Translated using Weblate (Hebrew) Currently translated at 47.3% (27 of 57 strings) Translated using Weblate (Ukrainian) Currently translated at 61.4% (35 of 57 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Portuguese) Currently translated at 99.6% (617 of 619 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (57 of 57 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Persian) Currently translated at 15.7% (9 of 57 strings) Translated using Weblate (Ukrainian) Currently translated at 54.3% (31 of 57 strings) Translated using Weblate (Lithuanian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Italian) Currently translated at 100.0% (619 of 619 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (619 of 619 strings) Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: AioiLight <[email protected]> Co-authored-by: Ajeje Brazorf <[email protected]> Co-authored-by: Danial Behzadi <[email protected]> Co-authored-by: Gediminas Murauskas <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Igor Nedoboy <[email protected]> Co-authored-by: Ihor Hordiichuk <[email protected]> Co-authored-by: Jakub <[email protected]> Co-authored-by: Jeff Huang <[email protected]> Co-authored-by: Priit Jõerüüt <[email protected]> Co-authored-by: Vasilis K <[email protected]> Co-authored-by: WB <[email protected]> Co-authored-by: Yaron Shahrabani <[email protected]> Co-authored-by: bruh <[email protected]> Co-authored-by: chr56 <[email protected]> Co-authored-by: nzgha <[email protected]> Co-authored-by: pjammo <[email protected]> Co-authored-by: ssantos <[email protected]> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fa/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/he/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata
Excuse me, but what is this? |
I'm sorry for my comment above. I didn't take a good look at this and mistook this for spam (we have a lot of that recently). I think I understand what's happening now. What you have done is open a pull request, or a PR, which is intended for making changes to NewPipe's code. What you probably wanted to do instead is open an issue, which is how you can report bugs, ask for features to be added, etc. This feature has already been requested in #4341. You can add a thumbs up reaction to that issue. Again, I apologize for the mistake. |
What is it?
-Feature (user facing)
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
Just an example.
Relies on the following changes
Sorry if this looks bad, it's my first time making a request.
Due diligence