(need help) Cover image feature #6278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut they do not function yet
…wPipe into feature-cover-image
|
Please don't change the README; it's unrelated to your changes. |
triallax
added
downloader
triallax
suggested changes
May 13, 2021
app/src/main/res/values/strings.xml
Outdated
| @@ -715,4 +715,8 @@ | |||
| <string name="night_theme_summary">Select your favorite night theme — %s</string> | |||
| <string name="select_night_theme_toast">You can select your favorite night theme below</string> | |||
| <string name="download_has_started">Download has started</string> | |||
| <string name="cover_image">Cover Image</string> | |||
| <string name="download_cover_preference_title">Initially add cover image</string> | |||
| <string name="download_cover_preference">cover_pref_key</string> | |||
There was a problem hiding this comment.
This particular line should go in settings_keys.xml, and you should set translatable="false" on it.
|
@mangoepic this can't be done without adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Relies on the following changes
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence