Fix downloading/exporting when overwriting file would not truncate #11745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR adds a method to open a file and immediately truncate it:
openAndTruncateStream()
. Database and subscription exports previously did not truncate the file before writing to it, resulting in corrupted files like in #7802 when the new content is shorter than the previous content. I looked at how the Downloader interacts with files, but the downloader correctly sets the length of the file before writing to it, so I did not change anything there. I tested on my phone (Android 13 SAF) and on API 22 emulated (SAF and NNFP) and it worked in both.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence