-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate empty_state_view xml/view to Jetpack Compose #11725
Migrate empty_state_view xml/view to Jetpack Compose #11725
Conversation
A manual test clicking through the build on an empty newpipe seems that everything still works as expected. |
|
I’d merge soon, unless there are any vetoes |
3c0b0be
to
e05eef0
Compare
e05eef0
to
ad72b2c
Compare
Wait |
I think that the component's parameters are needlessly complicated. The only three items in the spec should be:
|
Quality Gate passedIssues Measures |
I pushed a few more commits, and now the code is better in my opinion. These things still need to be improved though (I don't know if it's better to do them now or in a future PR):
I tested all the screens above, in dark and light themes, and they work. |
Looks exceptionally good to me! (disclaimer: I didn’t test, since you already made screenshots) |
Followup rebase for #11463 due to technical reasons.
Please see its description.