Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Coil 3 #11723

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Migrate to Coil 3 #11723

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a98b1d
Rename .java to .kt
Isira-Seneviratne Nov 20, 2024
ca855cb
Migrate to Coil 3
Isira-Seneviratne Nov 20, 2024
3a9540b
Update app/src/main/java/org/schabi/newpipe/App.kt
Isira-Seneviratne Nov 20, 2024
9f4a33c
Fix lint
Isira-Seneviratne Nov 21, 2024
d73314b
Make App instance variable immutable outside class
Isira-Seneviratne Nov 21, 2024
b584353
Small fixes to code style
Stypox Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ ext {

leakCanaryVersion = '2.12'
stethoVersion = '1.6.0'

coilVersion = '3.0.3'
}

configurations {
Expand Down Expand Up @@ -207,7 +209,7 @@ dependencies {
// This works thanks to JitPack: https://jitpack.io/
implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
// WORKAROUND: v0.24.2 can't be resolved by jitpack -> use git commit hash instead
implementation 'com.github.TeamNewPipe:NewPipeExtractor:176da72cb4c3ec4679211339b0e59f6b01bf2f52'
implementation 'com.github.TeamNewPipe:NewPipeExtractor:d3d5f2b3f03a5f2b479b9f6fdf1c2555cbb9de0e'
implementation 'com.github.TeamNewPipe:NoNonsense-FilePicker:5.0.0'

/** Checkstyle **/
Expand Down Expand Up @@ -272,7 +274,8 @@ dependencies {
implementation "com.github.lisawray.groupie:groupie-viewbinding:${groupieVersion}"

// Image loading
implementation 'io.coil-kt:coil-compose:2.7.0'
implementation "io.coil-kt.coil3:coil-compose:${coilVersion}"
implementation "io.coil-kt.coil3:coil-network-okhttp:${coilVersion}"

// Markdown library for Android
implementation "io.noties.markwon:core:${markwonVersion}"
Expand Down
279 changes: 0 additions & 279 deletions app/src/main/java/org/schabi/newpipe/App.java
View file
Open in desktop

This file was deleted.

Loading
Loading