-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement splash screen using Core Splashscreen library #11710
Implement splash screen using Core Splashscreen library #11710
Conversation
b090bdd
to
d424656
Compare
Can you test on a Samsung devices ? |
That doesn't seem to be necessary here, as this icon doesn't have a background (which is why the More information: https://developer.android.com/reference/kotlin/androidx/core/splashscreen/SplashScreen#themes This might be the issue with your splash screen: "On API < 31, if the value of windowSplashScreenAnimatedIcon is an adaptive icon , it will be cropped and scaled." |
My Pixel 6 is on Android 14, and there is not splash screen, it just enlarges the icon a little and then starts after maybe one second. Is it really necessary to add another dependency to implement a feature that is just nice-to-have? According to https://composables.com/android-distribution-chart more than half of devices are already on version 12 or later, so this code will be relevant maybe for a year or two. |
I guess removing the splash screen activity is a nice benefit, but maybe we don’t need a splash screen on older devices in the first place? |
That's strange, Android 14 should natively support the splash screen. |
The duration it is visible can be customised, so it could be used to mask the home screen's video loading process (if such a feature is needed). |
d424656
to
9c83226
Compare
a20de35
to
f850523
Compare
# Conflicts: # app/build.gradle
Quality Gate passedIssues Measures |
Mmmh I also think this is not so useful. Sure, animations are nice, but I don't see a big issue with the current splashscreen. At some point we could even remove the current splashscreen and use the default provided since Android 12+, to make things simpler. Thank you anyway for the proposal! |
What is it?
Description of the changes in your PR
This PR implements the app splash screen using the Core Splashscreen library. This allows a splash screen similar to that automatically generated on Android 12 and later to be displayed on older versions of Android. On Android 12 and later, an animated logo is used.
More information on Android 12's splash screen functionality: Splash screens
Before/After Screenshots/Screen Record
All versions of Android:
Screen_recording_20241116_143747.mp4
Android 5.0
Screen_recording_20241116_143153.webm
Android 6.0
Screen_recording_20241116_143343.webm
Android 15 (light theme)
Screen_recording_20241122_081416.mp4
Android 15 (dark theme)
Screen_recording_20241122_081529.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence