Fixed playlist order #11566
Merged
Fixed playlist order #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…playlist" dialog list. Now both lists are sorted using case insensitive order if the user has not yet adjusted manually the order.
|
nirodhvana
approved these changes
Sep 30, 2024
ShareASmile
added
the
waiting for review
Stypox
approved these changes
Nov 10, 2024
|
Thank you! |
ShareASmile
removed
the
waiting for review
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When user has not yet adjusted manually the playlists order the lists in "Bookmarked Playlists" and "add to playlist" dialog don't have the same order. Now in this phase both lists are sorted using case insensitive order. While after manual sorting from user both list keep the same order.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence