Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Android's elapsed time formatting #11244

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 7, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use Android's elapsed time formatting functionality to format durations. This allows the durations to be formatted in the same way as in the official YouTube app, and handles formatting depending on the locale.

Before/After Screenshots/Screen Record

Before After
Before After

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 7, 2024
Copy link

sonarqubecloud bot commented Jul 7, 2024

@Isira-Seneviratne Isira-Seneviratne requested a review from Stypox July 8, 2024 09:05
@Profpatsch
Copy link
Contributor

I tried it on current dev looks good, LGTM!

@Stypox Stypox merged commit 06d25b0 into TeamNewPipe:dev Nov 18, 2024
7 of 8 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Android-elapsed-time branch November 21, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants