DownloadDialog: remove thread selector #10735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing the number of download threads to users does not provide any value, because how should a user know how to set this value or what it means. Instead, we just set the default to 4 threads for now (the previous default), with the possibility of improving the default later (e.g. depending on other running downloads or device speed).
TobiGr
added
downloader
|
|
Thanks for your time, but I don't think it is a good idea to remove a feature like this one without any reason, especially as we will have a rewrite on which we will probably rework the download UI. Your PR is also a "feature" PR, which we don't currently accept. Due to the reasons stated above, I am closing your pull request. |
AudricV
removed
the
codequality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the number of download threads to users does not provide any value, because how should a user know how to set this value or what it means.
Instead, we just set the default to 4 threads for now (the previous default), with the possibility of improving the default later (e.g. depending on other running downloads or device speed).
What is it?
Description of the changes in your PR
^ removes the threads slider on the bottom of the download popup
Due diligence