Improve app signature check #10618
Merged
Improve app signature check #10618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
codequality
Isira-Seneviratne
force-pushed
the
Improve_signature_check
branch
from
9c9341a to
d9c0b2d
Compare
AudricV
requested changes
Feb 5, 2024
app/src/main/java/org/schabi/newpipe/util/ReleaseVersionUtil.kt
Outdated
Show resolved
Hide resolved
|
TobiGr
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Did you test your changes by using your own singing key? I tried to do so and it did not work for me.
What I did:
- Replace
RELEASE_CERT_PUBLIC_KEY_SHA256with the fingerprint of my key - build release APK and sign it
- install signed APK
- no "Updates" option in the settings, thus
ReleaseVersionUtil.INSTANCE.isReleaseApk()yieldsfalsein SettingsActivity.
Thanks, I'll recheck. Update: I fixed the issue. |
Isira-Seneviratne
force-pushed
the
Improve_signature_check
branch
from
901a383 to
4ae9376
Compare
|
AudricV
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
PackageInfoCompat.hasSignatures.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence