-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update miscellaneous libraries #10530
Conversation
9db4049
to
96a0e13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In a similar way to jsoup with its README.md
and CHANGES
files, RxJava is now adding LICENSE
and COPYRIGHT
files into its JARs: see https://github.com/ReactiveX/RxJava/blob/e6f152df7e2f2061435ee8ac3f6ed82cf34e3c58/build.gradle#L90-L94. Could you remove them?
I checked the built artifact, and it seems that only the COPYRIGHT file was there. LICENSE wasn't in the META-INF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good, thank you!
Have any dependency updates been released in the meantime? If so, could you apply them?
891ffe1
to
d13aa5e
Compare
Done. I didn't do Kotlin though, I want to update Ktlint first in another PR. |
Kudos, SonarCloud Quality Gate passed! |
a39b591
to
8eb5f1d
Compare
8eb5f1d
to
cda4b3f
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence