Magnify button

[joe61fa6f1awe]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• I added the full-screen button and exit-full screen button.
• I try to implement the rotation method. However, it seems the APP's layout is locked and the developers don't want the APP to rotate. Therefore, even though I implemented those rotation methods on the screen, the screen doesn't change the layout.

Before/After Screenshots/Screen Record

• Before
  There is no magnify button showing up on the screen.
  You can see the picture in the 4478

• After

Normal layout

The are two full-screen buttons on the video. One is the default, which is settled by developers on the previous version. The second one on the list is settled by me. However, no matter which one both of them can't do the rotation

Fixes the following issue(s)

• Fixes

• 10509

• 4478 but no completed fix it because I'm not sure if the developer meant to let the APP screen can't rotate or not

Relies on the following changes

• I changed the setting of the string.xml
• I added the full-screen and exit full-screen button on fragment_layout_detail.xml
• I also added new methods and buttons on the PlayQueueActivity class to show the buttons and implement the rotation method
• I modify some designs on the globalScreenOrientationLocked method and the MainPlayerUI class because they seems make the button disappear and cause the screen to be locked.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[AudricV]

Thank you for your pull request.

It seems you didn't look at the right place to edit the current fullscreen button, as you would have found how to make the app rotate.

Here is what you should have noticed and done in my opinion (this list is not exhaustive and should not be used as an "ultimate reference"):

• The screen orientation with the fullscreen button is currently set in VideoDetailFragment.onScreenRotationButtonClicked.
• In this VideoDetailFragment class, a ContentObserver attribute is used to remove the forced orientation when the device's automatic screen rotation is disabled.
• As the button is currently used when the device's automatic screen rotation is disabled, the usage of the SCREEN_ORIENTATION_PORTRAIT flag of the ActivityInfo class is made and would need to be changed to the ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED flag.
• In the MainPlayerUI class, the setupScreenRotationButton method is, like its name implies, responsible of hiding or showing the fullscreen button. This operation would need to be removed and the method could be renamed to setupScreenRotationButtonIcon.
• In this MainPlayerUI class, an other ContentObserver attribute is used to hide or show the fullscreen button using the setupScreenRotationButton method.
• The fullscreen button is also hidden by default in the XML layout in which it is declared, so you would need to remove the android:visibility property set to the gone value to the button.

Note that this approach has the disadvantage that if the device is physically in landscape (and so that the corresponding sensor reports this), the user enabled automatic rotation, and the app is in landscape, when the user will press the fullscreen button, nothing will happen.

Please don't do unrelated changes to the topic of your changes, so removing blank lines in unrelated files or changing a dependency should not be committed.

If you didn't do so, you should have asked yourself if putting a fullscreen button in a play queue activity makes sense or not (the answer is no).

I noticed this comment in your changes of PlayQueueActivity: // If you're using an ActionBar, hide it. I don't want to judge you, but in general, I think you should adapt answers from forums, blogs or AIs to the project on which you work on. This comment feels that you copy-pasted an answer.

Pull requests you made should be generally in the default branch we set, so except in very rare cases or bug regression fixes during a release candidate, you should use the dev branch and not another one like you did (this could be changed without closing a PR).

Finally, please try to explain your changes in a more direct way and follow the template properly in the future.

Due to the reasons above, we can't merge your pull request unfortunately.

You don't need to work on this feature anymore, I already started a while ago to work on this without submitting a pull request.

I am closing your pull request, please do not take this result as a bad experience but as a learning one :)

P.S.: That's a fullscreen button, not a magnify one.