Add playlist name and video name in playlist sharing content

[snaik20]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Add playlist name and video name in playlist sharing content

• Currently, only a list of videos separated by newline are added in
  the share content.
• This makes it difficult to identify a specific video in a list of
  Urls.
• Used string resources for the sharing content formats.
• Added a confirmation dialog for users to choose between sharing
  playlist formats.
• Added Playlist name as the header and corresponding video name for
  each video Url in following format.

My Playlist
- Music1: https://media-url1
- Music2: https://media-url2
- Music3: https://media-url3

Before/After Screenshots/Screen Record

Before	After	Confirmation Dialog

Video demo:

Playlist_Sharing_Update_Demo.mp4

Fixes the following issue(s)

• Supersedes and closes Added Playlist and video names to local playlist sharing #9060
• Fixes Playlist sharing: include video names & playlist name #9025

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.
  Note: I am aware of the NewPipe rewrite, and I would be open to updating my PR as per requirements.

[TobiGr]

Thank you for the changes. Please add screenshots of the share sheets showing the state before and after your PR.

[snaik20]

@TobiGr Thanks for your inputs, updated the PR with screenshots.

[TobiGr]

Thanks!
Sometimes, people just need to URLs to be exported. Please add a preference to the ContentSettings which allows the user to export a list of URLs only.

[TobiGr]

@Stypox just commented on Matrix that a dialog before sharing is better than a setting. He is correct. So please do not add a setting but rather an AlertDialog with a checkmark which enables the user to add the video title and playlist name

[snaik20]

@TobiGr Added a confirmation dialog to the playlist sharing process, allowing users to choose between sharing playlist formats. Users can also choose to save their sharing format preference to skip the confirmation dialog. In addition, an option has been added to the settings to update the sharing preference.

[TobiGr]

Thank you

[snaik20]

Thanks @TobiGr for your time and review. Updated the changes as requested. Let us wait for @opusforlife2 for inputs on the settings item.

[opusforlife2]

There's no good place to put it, unfortunately. Content menu is our current catch-all for miscellaneous settings. (If someone would like to tackle #9587 it would make everyone's lives easier. wink wink)

But why do we need a setting for this at all? Just have the checkbox state remembered. That one extra dialogue doesn't make much of a difference.

[snaik20]

There's no good place to put it, unfortunately. Content menu is our current catch-all for miscellaneous settings. (If someone would like to tackle #9587 it would make everyone's lives easier. wink wink)

But why do we need a setting for this at all? Just have the checkbox state remembered. That one extra dialogue doesn't make much of a difference.

Hi @opusforlife2,

Thanks for your feedback.

I understand your concern about the extra dialog, but I believe it's important to give users the option to choose how they want to share their playlists. Some users may prefer the convenience of having a checkbox that remembers their preference, while others may want to be more deliberate about how they share their playlists.

That said, I'm open to other suggestions. Here are a few options:

• We could remove the setting item and display the dialog every time a user shares a playlist.
• We could remove the dialog and only keep the setting, and let the user know where to find the setting item to change the default behavior.

I'm happy to discuss these options further with you, or to implement any other solution that you think would be better.

Regarding #9587, I agree that it would be great if someone could tackle it. I would be happy to look into it.

Thanks

[opusforlife2]

every time a user shares a playlist

I can't think of any obvious use cases where an average user would need to rapidly go through playlists and share them. At best this would be a one-off task. Apart from that, there could be an occasional desire to share an interesting playlist with a friend. This is why I suggested to go with:

We could remove the setting item and display the dialog every time

Can you think of any important use cases that are frequent enough to justify an additional setting?

[snaik20]

Playlist_Sharing_Demo.mp4

every time a user shares a playlist

I can't think of any obvious use cases where an average user would need to rapidly go through playlists and share them. At best this would be a one-off task. Apart from that, there could be an occasional desire to share an interesting playlist with a friend. This is why I suggested to go with:

We could remove the setting item and display the dialog every time

Can you think of any important use cases that are frequent enough to justify an additional setting?

Hi @opusforlife2,

I think you make a good point. I can't think of any use cases where the average user would need to rapidly share playlists. I have updated the flow to always show the dialog and updated the video demo.

WDYT

[opusforlife2]

Awesome! The flow looks great.

One last thing. Instead of saying "Share with details", I think the button should say "Share with titles". That's a little more descriptive of its function.

[snaik20]

@opusforlife2 Thanks, updated.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[TobiGr]

Thanks!

[TobiGr]

I fixed the wrongly formatted string resources in 0758cd6

[snaik20]

I fixed the wrongly formatted string resources in 0758cd6

Thanks @TobiGr