Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.21.14 - watched items not removed from feed unless "hide watched" toggle cycled #7545

Open
4 tasks done
perseusbiscuitsakira opened this issue Dec 16, 2021 · 4 comments
Open
4 tasks done
Labels
bug Issue is related to a bug feed Issue is related to the feed

Comments

@perseusbiscuitsakira
Copy link

perseusbiscuitsakira commented Dec 16, 2021

Steps to reproduce the bug

  1. Go to 'What's New' i.e. Feeds
  2. Watch a video or 'Mark as watched' while the having 'Show watched items' set to off (slashed eye)

Actual behavior

Videos will not be removed from feed unless you refresh feed or toggle 'Show watched items' (from 'slashed eye' to 'normal eye' and back to 'slashed eye')

Expected behavior

In v0.21.13 and previous releases, Videos would be removed as soon as watched or 'Marked as watched' while the 'Show watched items' setting was set to off (slashed eye), without the need to cycle the setting

Device info

  • Device model: Amazon Fire HD 10 Plus tablet
@perseusbiscuitsakira perseusbiscuitsakira added the bug Issue is related to a bug label Dec 16, 2021
@XiangRongLin XiangRongLin added the feed Issue is related to the feed label Dec 18, 2021
@litetex
Copy link
Member

litetex commented Dec 18, 2021

Videos will not be removed from feed unless Watched(Eye Icon) is cycled

Correction: Videos will not be removed until the feed is refreshed.

@muuusso
Copy link

muuusso commented Jan 10, 2022

Experiencing the same here. Definitely not a deal breaker, but an annoying behavior. Hopeful you will restore it quickly.

@Stypox
Copy link
Member

Stypox commented Jan 27, 2022

@litetex commit 676bc02 contained in #7050 broke updates in the feed. Now marking an item as watched (or actually watching it) does not update its visual state until the feed items are reloaded in some way (e.g. by pressing the eye two times, or by reloading the feed, or ...).

@litetex
Copy link
Member

litetex commented Jan 27, 2022

@Stypox
Keep in mind that this was a fix for #6686 (comment) / #6686 (comment).

Fun Fact: It also doesn't work in any other list → This is a new feature in my opinion
I think something like broadcasting an event (and not using the database as a notification platform because a database is a database and not a message broker) when a video is watched and reacting to it would be good solution (maybe something like notifyDataChanged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug feed Issue is related to the feed
Projects
None yet
Development

No branches or pull requests

5 participants