Skip to content

Commit

Permalink
Update extractor and remove DeobfuscateException
Browse files Browse the repository at this point in the history
In ErrorInfo it was treated separately from other ParsingExceptions, including by showing a customized message, which has now been removed.
  • Loading branch information
Stypox committed Sep 22, 2023
1 parent b508dd6 commit bdc2aa2
Show file tree
Hide file tree
Showing 74 changed files with 1 addition and 75 deletions.
2 changes: 1 addition & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ dependencies {
// name and the commit hash with the commit hash of the (pushed) commit you want to test
// This works thanks to JitPack: https://jitpack.io/
implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
implementation 'com.github.TeamNewPipe:NewPipeExtractor:3be76a6406d59f1fd8eedf5fab6552e6c2a3da76'
implementation 'com.github.TeamNewPipe:NewPipeExtractor:289db1178ab66694c23893e6a487d4708343c47b'
implementation 'com.github.TeamNewPipe:NoNonsense-FilePicker:5.0.0'

/** Checkstyle **/
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/java/org/schabi/newpipe/error/ErrorInfo.kt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import org.schabi.newpipe.extractor.exceptions.AccountTerminatedException
import org.schabi.newpipe.extractor.exceptions.ContentNotAvailableException
import org.schabi.newpipe.extractor.exceptions.ContentNotSupportedException
import org.schabi.newpipe.extractor.exceptions.ExtractionException
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.DeobfuscateException
import org.schabi.newpipe.ktx.isNetworkRelated
import org.schabi.newpipe.util.ServiceHelper

Expand Down Expand Up @@ -96,7 +95,6 @@ class ErrorInfo(
throwable is ContentNotAvailableException -> R.string.content_not_available
throwable != null && throwable.isNetworkRelated -> R.string.network_error
throwable is ContentNotSupportedException -> R.string.content_not_supported
throwable is DeobfuscateException -> R.string.youtube_signature_deobfuscation_error
throwable is ExtractionException -> R.string.parsing_error
throwable is ExoPlaybackException -> {
when (throwable.type) {
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-ar/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
<string name="could_not_load_thumbnails">تعذر تحميل كافة الصور المصغرة</string>
<string name="general_error">خطأ</string>
<string name="parsing_error">تعذر تحليل الموقع</string>
<string name="youtube_signature_deobfuscation_error">تعذر فك تشفير توقيع رابط الفيديو</string>
<string name="main_bg_subtitle">اضغط على عدسة المكبرة للبدء.</string>
<string name="subscribe_button_title">اشتراك</string>
<string name="subscribed_button_title">مشترك</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-az/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,6 @@
<string name="settings_category_player_notification_title">Oynadıcı bildirişi</string>
<string name="streams_notification_channel_name">Yeni yayımlar</string>
<string name="error_report_channel_name">Xəta hesabatı bildirişi</string>
<string name="youtube_signature_deobfuscation_error">Video URL\'i imzası şifrəsi qırılmadı</string>
<string name="no_streams_available_download">Endirmək üçün yayım mövcud deyil</string>
<string name="error_report_notification_toast">Xəta baş verdi, bildirişi gör</string>
<string name="your_comment">Şərhiniz (İngiliscə):</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-b+ast/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
<string name="duration_live">En direuto</string>
<string name="general_error">Fallu</string>
<string name="could_not_load_thumbnails">Nun pudieron cargase toles miniatures</string>
<string name="youtube_signature_deobfuscation_error">Nun pudo sabese la robla de la URL del videu</string>
<string name="parsing_error">Nun pudo analizase\'l sitiu web</string>
<string name="sorry_string">Buff… Esto nun debió asoceder.</string>
<string name="error_snackbar_message">Perdona mas asocedió daqué malo.</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-b+uz+Latn/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@
<string name="could_not_setup_download_menu">Yuklab olish menyusi sozlanmadi</string>
<string name="content_not_available">Tarkib mavjud emas</string>
<string name="parsing_error">Veb-saytni tahlil qilib bo\'lmadi</string>
<string name="youtube_signature_deobfuscation_error">Videoning URL manzilini o\'chirib bo\'lmadi</string>
<string name="could_not_load_thumbnails">Barcha eskizlarni yuklab bo\'lmadi</string>
<string name="network_error">Tarmoqda xato</string>
<string name="download_to_sdcard_error_message">Tashqi SD-kartaga yuklab olishning iloji yo\'q. Yuklash papkasining joylashuvi tiklansinmi\?</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-be/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@
<string name="general_error">Памылка</string>
<string name="network_error">Памылка сеткі</string>
<string name="could_not_load_thumbnails">Не атрымалася загрузіць усе мініяцюры</string>
<string name="youtube_signature_deobfuscation_error">Не атрымалася расшыфраваць подпіс URL у відэа</string>
<string name="parsing_error">Не атрымалася разабраць вэб-сайт</string>
<string name="content_not_available">Кантэнт недаступны</string>
<string name="could_not_setup_download_menu">Не атрымалася стварыць меню загрузкі</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-bg/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@
<string name="clear_search_history_summary">Изтрива историята с въвежданите за търсене ключови думи</string>
<string name="delete_search_history_alert">Изтрий цялата история на търсенията\?</string>
<string name="search_history_deleted">Историята на търсенията е изтрита.</string>
<string name="youtube_signature_deobfuscation_error">URL подписът на клипа не можа да бъде дешифрован</string>
<string name="external_player_unsupported_link_type">Външните плейъри не поддържат този вид линкове</string>
<string name="invalid_directory">Невалидна директория</string>
<string name="invalid_source">Невалиден файл или източник на съдържание</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-bn-rBD/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
<string name="general_error">ত্রুটি</string>
<string name="network_error">নেটওয়ার্ক ত্রুটি</string>
<string name="could_not_load_thumbnails">সব থাম্বনেইল লোড করা যায়নি</string>
<string name="youtube_signature_deobfuscation_error">ভিডিও URL স্বাক্ষর ডিক্রিপ্ট করা যায়নি</string>
<string name="parsing_error">ওয়েবসাইট বিশ্লেষন করা যায়নি</string>
<string name="content_not_available">কন্টেন্ট উপলব্ধ নয়</string>
<string name="could_not_setup_download_menu">ডাউনলোড মেনু সেটআপ করা যায়নি</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-bn-rIN/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
<string name="could_not_setup_download_menu">ডাউনলোড মেনু সেটআপ করা যায়নি</string>
<string name="content_not_available">কন্টেন্ট উপলব্ধ নয়</string>
<string name="parsing_error">ওয়েবসাইট বিশ্লেষন করা যায়নি</string>
<string name="youtube_signature_deobfuscation_error">ভিডিও URL স্বাক্ষর ডিক্রিপ্ট করা যায়নি</string>
<string name="could_not_load_thumbnails">সব থাম্বনেইল লোড করা যায়নি</string>
<string name="network_error">নেটওয়ার্ক ত্রুটি</string>
<string name="general_error">ত্রুটি</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-bn/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@
<string name="could_not_setup_download_menu">ডাউনলোড মেনু সেটআপ করা যায়নি</string>
<string name="content_not_available">কন্টেন্ট উপলব্ধ নয়</string>
<string name="parsing_error">ওয়েবসাইট বিশ্লেষন করা যায়নি</string>
<string name="youtube_signature_deobfuscation_error">ভিডিও URL স্বাক্ষর ডিক্রিপ্ট করা যায়নি</string>
<string name="could_not_load_thumbnails">সব থাম্বনেইল লোড করা যায়নি</string>
<string name="network_error">নেটওয়ার্ক ত্রুটি</string>
<string name="download_to_sdcard_error_title">বাহ্যিক স্টোরেজ নেই</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-ca/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@
<string name="notification_channel_name">Notificació de NewPipe</string>
<string name="notification_channel_description">Notificacions per al reproductor de NewPipe</string>
<string name="could_not_load_thumbnails">No s\'han pogut carregar totes les miniatures</string>
<string name="youtube_signature_deobfuscation_error">No s\'ha pogut desxifrar la signatura de l\'URL del vídeo</string>
<string name="parsing_error">No s\'ha pogut processar el lloc web</string>
<string name="content_not_available">Contingut no disponible</string>
<string name="could_not_setup_download_menu">No s\'ha pogut configurar el menú de baixades</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-ckb/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,6 @@
<string name="invalid_directory">هەمان فۆڵدەر بوونی نییە</string>
<string name="bookmark_playlist">نیشانه‌كردنی خشته‌لێدان</string>
<string name="file_name_empty_error">ناوی فایل ناکرێت بەتاڵ بێت</string>
<string name="youtube_signature_deobfuscation_error">ناتوانرێت واژووی بەستەری ڤیدیۆ بخوێنرێتەوە</string>
<string name="updates_setting_description">پیشاندانی پەیامێک بۆ ئامادەبوونی به‌رنامه‌ لەکاتی بەردەست بوونی وەشانی نوێ</string>
<string name="enable_watch_history_title">مێژووی سەیرکردن</string>
<string name="enable_disposed_exceptions_title">سکاڵا لەسەر کێشەکان</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-cs/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
<string name="general_error">Chyba</string>
<string name="network_error">Chyba sítě</string>
<string name="could_not_load_thumbnails">Nebylo možné nahrát všechny náhledy</string>
<string name="youtube_signature_deobfuscation_error">Nebylo možné dekódovat URL videa</string>
<string name="parsing_error">Nebylo možné analyzovat stránku</string>
<string name="content_not_available">Obsah není k dispozici</string>
<string name="detail_thumbnail_view_description">Přehrát video, délka:</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-da/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@
<string name="download_to_sdcard_error_message">Det er endnu ikke muligt at downloade til et eksternt SD-kort. Nulstil download-mappens placering\?</string>
<string name="network_error">Netværksfejl</string>
<string name="could_not_load_thumbnails">Kunne ikke indlæse alle miniaturebilleder</string>
<string name="youtube_signature_deobfuscation_error">Kunne ikke dekryptere URL-signatur for video</string>
<string name="parsing_error">Kunne ikke analysere websted</string>
<string name="content_not_available">Indhold ikke tilgængeligt</string>
<string name="could_not_setup_download_menu">Kunne ikke oprette downloadmenu</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
<string name="settings_category_appearance_title">Aussehen</string>
<string name="general_error">Fehler</string>
<string name="could_not_load_thumbnails">Konnte nicht alle Vorschaubilder laden</string>
<string name="youtube_signature_deobfuscation_error">Konnte Video-URL-Signatur nicht entschlüsseln</string>
<string name="parsing_error">Konnte Webseite nicht analysieren</string>
<string name="content_not_available">Inhalt nicht verfügbar</string>
<string name="content">Inhalt</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-el/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@
<string name="delete_search_history_alert">Διαγραφή ολόκληρου του ιστορικού αναζητήσεων;</string>
<string name="search_history_deleted">Το ιστορικό αναζητήσεων διαγράφηκε</string>
<string name="could_not_load_thumbnails">Δεν ήταν δυνατή η φόρτωση όλων των εικονιδίων</string>
<string name="youtube_signature_deobfuscation_error">Δεν ήταν δυνατή η αποκρυπτογράφηση της υπογραφής της URL του βίντεο</string>
<string name="parsing_error">Δεν ήταν δυνατή η ανάλυση του ιστοτόπου</string>
<string name="content_not_available">Το περιεχόμενο δεν είναι διαθέσιμο</string>
<string name="could_not_setup_download_menu">Δεν ήταν δυνατή η ρύθμιση του μενού λήψεων</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-eo/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
<string name="kore_not_found">Ĉu instali la mankan aplikaĵon Kore\?</string>
<string name="show_next_and_similar_title">Montri \'Sekvajn\' kaj \'Similajn\' videojn</string>
<string name="could_not_load_thumbnails">Ĉiuj bildetoj ne ŝargeblas</string>
<string name="youtube_signature_deobfuscation_error">La subskribo de la ligilo de la filmeto ne malĉifreblas</string>
<string name="parsing_error">La retejo ne analizeblas</string>
<string name="detail_thumbnail_view_description">Ludi filmeton, daŭro:</string>
<string name="detail_uploader_thumbnail_view_description">Bildeto de la alŝutinto</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
<string name="general_error">Error</string>
<string name="network_error">Error de conexión</string>
<string name="could_not_load_thumbnails">No se pudo cargar las miniaturas</string>
<string name="youtube_signature_deobfuscation_error">No se pudo descifrar la URL del vídeo</string>
<string name="parsing_error">No se pudo analizar el sitio web</string>
<string name="show_next_and_similar_title">Mostrar vídeos \'Siguientes\' y \'Similares\'</string>
<string name="content_language_title">Idioma predefinido del contenido</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-et/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@
<string name="general_error">Viga</string>
<string name="network_error">Võrgu viga</string>
<string name="could_not_load_thumbnails">Kõiki pisipilte ei õnnestunud laadida</string>
<string name="youtube_signature_deobfuscation_error">Video URLi dekrüptimine nurjus</string>
<string name="parsing_error">Veebilehe töötlemine nurjus</string>
<string name="content_not_available">Sisu pole saadaval</string>
<string name="could_not_setup_download_menu">Allalaadimismenüü seadistamine nurjus</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-eu/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
<string name="general_error">Errorea</string>
<string name="network_error">Sare-errorea</string>
<string name="could_not_load_thumbnails">Ezin izan dira iruditxo guztiak deskargatu</string>
<string name="youtube_signature_deobfuscation_error">Ezin izan da bideoaren URL sinadura deskodetu</string>
<string name="parsing_error">Ezin izan da webgunea analizatu</string>
<string name="content_not_available">Edukia ez dago eskuragarri</string>
<string name="could_not_setup_download_menu">Ezin izan da deskargen menua ezarri</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-fa/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
<string name="general_error">خطا</string>
<string name="network_error">خطای شبکه</string>
<string name="could_not_load_thumbnails">نمی‌توان تمام بندانگشتی‌ها را بار کرد</string>
<string name="youtube_signature_deobfuscation_error">نمی‌توان امضای نشانی اینترنتی ویدیو را رمزگشایی کرد</string>
<string name="parsing_error">نمی‌توان پایگاه وب را تجزیه کرد</string>
<string name="content_not_available">محتوا در دسترس نیست</string>
<string name="could_not_setup_download_menu">نمی‌توان فهرست بارگیری را برپا ساخت</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-fi/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
<string name="general_error">Virhe</string>
<string name="network_error">Verkkovirhe</string>
<string name="could_not_load_thumbnails">Kaikkia esikatselukuvia ei voitu ladata</string>
<string name="youtube_signature_deobfuscation_error">Videon URL-allekirjoituksen salausta ei voitu purkaa</string>
<string name="parsing_error">Verkkosivua ei voitu jäsentää</string>
<string name="content_not_available">Sisältö ei ole saatavilla</string>
<string name="could_not_setup_download_menu">Latausvalikkoa ei voitu asettaa</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
<string name="show_age_restricted_content_title">Afficher le contenu avec limite d’âge</string>
<string name="duration_live">En direct</string>
<string name="could_not_load_thumbnails">Impossible de charger toutes les miniatures</string>
<string name="youtube_signature_deobfuscation_error">Impossible de déchiffrer la signature URL de la vidéo</string>
<string name="sorry_string">Désolé, cela n’aurait pas dû se produire.</string>
<string name="error_report_button_text">Signaler par courriel</string>
<string name="what_device_headline">Information :</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-gl/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@
<string name="general_error">Erro</string>
<string name="network_error">Erro de rede</string>
<string name="could_not_load_thumbnails">Non foi posíbel carregar todas as miniaturas</string>
<string name="youtube_signature_deobfuscation_error">Non foi posíbel descifrar a asinatura do vídeo</string>
<string name="parsing_error">Non foi posíbel procesar o sitio web</string>
<string name="content_not_available">Contido non dispoñíbel</string>
<string name="could_not_setup_download_menu">Non foi posíbel configurar o menú de descargas</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-he/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
<string name="general_error">שגיאה</string>
<string name="network_error">שגיאת רשת</string>
<string name="could_not_load_thumbnails">אין אפשרות לטעון את כל התמונות הממוזערות</string>
<string name="youtube_signature_deobfuscation_error">לא ניתן לפענח את חתימת כתובת הסרטון</string>
<string name="parsing_error">ניתוח האתר לא התאפשר</string>
<string name="content_not_available">תוכן אינו זמין</string>
<string name="could_not_setup_download_menu">לא הייתה אפשרות להכין את תפריט ההורדה</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-hi/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
<string name="general_error">त्रुटी</string>
<string name="network_error">नेटवर्क में त्रुटी</string>
<string name="could_not_load_thumbnails">सारे thumbnail(फोटो जो फ़ोन की मेमोरी में है ) भरे नहीं जा सकते</string>
<string name="youtube_signature_deobfuscation_error">वीडियो के URL हस्ताक्षर को डीऑबफस्केट नहीं कर सकते</string>
<string name="parsing_error">इस website का निरंक्षण नहीं कर सकते</string>
<string name="content_not_available">विषय वस्तु उपलब्ध नहीं है</string>
<string name="could_not_setup_download_menu">डाउनलोड मेनू को स्थापित नहीं कर सकते</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-hr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
<string name="general_error">Greška</string>
<string name="network_error">Greška u mreži</string>
<string name="could_not_load_thumbnails">Nije bilo moguće učitati sve sličice</string>
<string name="youtube_signature_deobfuscation_error">Nije bilo moguće dešifrirati URL potpis videozapisa</string>
<string name="parsing_error">Nije bilo moguće obraditi stranicu</string>
<string name="content_not_available">Sadržaj nije dostupan</string>
<string name="could_not_setup_download_menu">Nije bilo moguće postaviti izbornik za preuzimanje</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-hu/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
<string name="sorry_string">Elnézést, ennek nem kellett volna megtörténnie.</string>
<string name="error_report_button_text">Jelentés e-mailben</string>
<string name="could_not_setup_download_menu">Nem sikerült a letöltési menü beállítása</string>
<string name="youtube_signature_deobfuscation_error">Nem sikerült a videó URL aláírásának feloldása</string>
<string name="retry">Újra</string>
<string name="video">Videó</string>
<string name="audio">Hang</string>
Expand Down
Loading

0 comments on commit bdc2aa2

Please sign in to comment.