Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Github actions #12

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Bump Github actions #12

merged 1 commit into from
Feb 1, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Jan 31, 2024

Github drops support to Node JS 16 in Github actions -> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
This PR:

I have already made these changes in other repositories without break changes

Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@XiangRongLin XiangRongLin merged commit 996c063 into TeamNewPipe:github_actions Feb 1, 2024
@Jean-BaptisteC Jean-BaptisteC deleted the gh_actions branch February 1, 2024 09:37
@ShareASmile
Copy link

ShareASmile commented Feb 3, 2024

@XiangRongLin Forgive me I am bit late here, this PR fixes only deprications not errors, signing process still needs to be fixed.
See erors in https://github.com/TeamNewPipe/NewPipe-nightly/actions/runs/7689641241
due to r0adkll/sign-android-release#84

Brave NewPipe has been patched by evermind-zz this way here

Or switch out the action to something more maintained instead like alvr-org/ALVR-nightly#8

@XiangRongLin
Copy link
Collaborator

@ShareASmile Thank you. I did not realise that the workflow does not try to release on the next day after a fail. So i thought it fixed itself.
I'll take a look this/next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants