✨ [FEAT] 과방탭 질문 메인뷰 디자인 수정사항 대응 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# 본문은 위에 작성 ######## 본문은 한 줄에 최대 72 글자까지만 입력 ########################### -> | # 꼬릿말은 아래에 작성: ex) #이슈 번호 # --- COMMIT END --- # <타입> 리스트 # feat : 기능 (새로운 기능) # fix : 버그 (버그 수정) # refactor: 리팩토링 # style : 스타일 (코드 형식, 세미콜론 추가: 비즈니스 로직에 변경 없음) # docs : 문서 (문서 추가, 수정, 삭제) # test : 테스트 (테스트 코드 추가, 수정, 삭제: 비즈니스 로직에 변경 없음) # chore : 기타 변경사항 (빌드 스크립트 수정 등) # ------------------ # 제목 첫 글자를 대문자로 # 제목은 명령문으로 # 제목 끝에 마침표(.) 금지 # 제목과 본문을 한 줄 띄워 분리하기 # 본문은 "어떻게" 보다 "무엇을", "왜"를 설명한다. # 본문에 여러줄의 메시지를 작성할 땐 "-"로 구분 # ------------------
hwangJi-dev
added
📱 View
jane1choi
approved these changes
Mar 3, 2022
| NotificationCenter.default.addObserver(self, selector: #selector(updateDataBySelectedMajor), name: Notification.Name.dismissHalfModal, object: nil) | ||
| } | ||
|
|
||
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
| override func viewDidAppear(_ animated: Bool) { | ||
| setUpRequestData() |
dev-jungbin
approved these changes
Mar 3, 2022
| private func updateEntireQuestionTV() { | ||
| DispatchQueue.main.async { | ||
| self.entireQuestionTV.reloadData() | ||
| self.entireQuestionTV.layoutIfNeeded() |
There was a problem hiding this comment.
요기 layoutIfNeeded() 이후에 automaticDimension 다시 호출해도 안됏어? ㅠ
There was a problem hiding this comment.
호출시점을 바꿔봐도 두번정도 reload를 시켜야 얘가 딱 맞네 뭐 학습되는건가 ㅋㅋㅋ
hwangJi-dev
deleted the
feature/#249-UI-Classroom-QuestionMain-DesignEdit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍎 관련 이슈
closed #249
🍎 변경 사항 및 이유
🍎 PR Point
📸 ScreenShot