Add guard for empty string at port textfield in SftpConnectionDialog #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference At ContextLocaleExt.kt, remove conflicting locales API 24 or above
TranceLove
added
Issue-Bug
VishnuSanal
approved these changes
Mar 25, 2024
VishalNehra
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
Fixes #4122
Manual tests
Done
Device: Pixel 4a emulator
OS: Android 12
When connection is set up with server port at 22, editing connection should not crash the app
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckRelated PR
Related to PR #4092 - cherry picked 88ac4ed to make tests pass