Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard dependency info in apk and stricten cleartext traffic to local streamer only #4085

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

TranceLove
Copy link
Collaborator

@TranceLove TranceLove commented Feb 19, 2024

Description

  • Allow cleartext traffic only at localhost, which is required for streaming media over network
  • Disable include dependency info in built apk. Not much advantage from this, and Google would encrypt it using its own method, hence remove it altogether

Issue tracker

Fixes #4084
Fixes #4088

Manual tests

  • Done

  • Pixel 2 emulator, running Android 7.1.1

  • Pixel 6 emulator, running Android 13

Streaming media from remote server should continue work without problem.

APK proprietary blob existence check, may rely on @IzzySoft's help instead

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@VishalNehra VishalNehra merged commit 604c680 into release/3.10 Mar 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants