Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide FAB in some screens #4071

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Conversation

seelchen
Copy link
Contributor

@seelchen seelchen commented Feb 5, 2024

Description

This PR hides the FAB in screens where it doesn't make sense to show it, for example the "Trashbin" or "Recent files" since no files or folders can be added there.

Issue tracker

Fixes #3997

Automatic tests

  • Added test cases

Manual tests

  • Done

Devices:

  • Pixel 7 emulator running Android 13
  • HTC U11 life running Android 10

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

The boolean specifies if the FAB should be shown when the entry is
clicked
It determines if the FAB is shown or not when there is a MainFragment
Since each MainFragment can be in different paths, the information if
the FAB should be shown or not should be stored there
Since each tab has different `MainFragments` and they might have different
behaviors for the FAB
@seelchen seelchen marked this pull request as ready for review February 10, 2024 18:37
@VishalNehra VishalNehra merged commit 8fcbe7e into TeamAmaze:release/4.0 Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide FAB from screens other than the home screen
2 participants