Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search landscape bugfix #4060

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Search landscape bugfix #4060

merged 2 commits into from
Jan 28, 2024

Conversation

VishnuSanal
Copy link
Member

@VishnuSanal VishnuSanal commented Jan 27, 2024 •
edited
Loading

Fixes #4059

todo

  • test on API19 & API20 (why not?) since android:elevation was introduced in API21

tested it on an emulator & it works fine :)

@VishnuSanal VishnuSanal changed the base branch from release/4.0 to release/3.10 January 27, 2024 17:38
@VishnuSanal VishnuSanal added the Issue-Severe (high) Showstopper issues that require immediate attention label Jan 27, 2024
@VishnuSanal
Copy link
Member Author

Build test APK

@github-actions GitHub Actions
Copy link

The requested APKs has been built. Please find them from the artifacts section of this PR.

@VishalNehra VishalNehra merged commit 4d65efb into release/3.10 Jan 28, 2024
5 checks passed
@VishalNehra VishalNehra deleted the search-landscape-bug branch January 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishalNehra VishalNehra VishalNehra approved these changes

@TranceLove TranceLove Awaiting requested review from TranceLove

Assignees
No one assigned
Labels
Issue-Severe (high) Showstopper issues that require immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New search UI not visible on landscape orientation
2 participants
@VishnuSanal @VishalNehra