Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore fixes in TextEditorActivity and FtpNotification #3964

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

TranceLove
Copy link
Collaborator

Description

  • FtpNotification use NotificationManagerCompat to ensure compatibility
  • TextEditorActivity added a couple of null checks to make linter happier

Issue tracker

Fixes #768

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove TranceLove added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Oct 23, 2023
@TranceLove TranceLove added this to the v4.0 milestone Oct 23, 2023
@TranceLove TranceLove self-assigned this Oct 23, 2023
- FtpNotification use NotificationManagerCompat to ensure compatibility
- TextEditorActivity added a couple of null checks to make linter happier

Fixes #768
VishnuSanal added a commit that referenced this pull request Oct 24, 2023
VishalNehra
VishalNehra previously approved these changes Oct 30, 2023
@VishalNehra VishalNehra removed this from the v4.0 milestone Oct 30, 2023
@VishalNehra VishalNehra merged commit 2c9f9e6 into release/4.0 Oct 30, 2023
0 of 2 checks passed
@VishalNehra VishalNehra deleted the bugfix/768 branch October 30, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are lines of code that require higher API versions
2 participants