Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3961 #3962

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fixes #3961 #3962

merged 2 commits into from
Oct 30, 2023

Conversation

VishnuSanal
Copy link
Member

Description

Issue tracker

Fixes #3961

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove
Copy link
Collaborator

Bit weird they are not seeing this at upstream commons-compress library, even in their current master

https://github.com/apache/commons-compress/blob/bc50be9fcabd1260afe7b66e631316ae6ecdab7d/src/main/java/org/apache/commons/compress/archivers/sevenz/AES256SHA256Decoder.java#L74-L85

Decent to trap this exception to prevent crash IMO.

@VishalNehra VishalNehra merged commit 4161845 into release/4.0 Oct 30, 2023
3 checks passed
@VishalNehra VishalNehra deleted the issue/3961 branch October 30, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoderMalfunctionError on CharsetEncoder#encode
3 participants