Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ls lines for (even more) legacy devices #3960

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

TranceLove
Copy link
Collaborator

@TranceLove TranceLove commented Oct 21, 2023

Description

For GPD XD Gen 1 running LegacyROM (4.4.4), where its ls command is not returning any number for directory size (usually 1 or 4096)

drwxr-xr-x root     root              2023-10-21 13:57 acct

Automatic tests

  • Added test cases

Manual tests

  • Done

Device: GPD XD Gen 1
OS: Legacy ROM (4.4.4)

Root explorer should continue to function when listing files at root /

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

For GPD XD Gen 1 running LegacyROM (4.4.4), where its ls command is not returning any number for directory size (usually 1 or 4096)
@TranceLove TranceLove added the Issue-Bug Related unexpected behavior or something worth investigating. label Oct 21, 2023
@TranceLove TranceLove added this to the v4.0 milestone Oct 21, 2023
@VishalNehra VishalNehra merged commit 0beaea2 into release/4.0 Oct 30, 2023
1 of 2 checks passed
@VishalNehra VishalNehra deleted the bugfix/parseFileLinesForLegacyDevices branch October 30, 2023 00:05
@TranceLove TranceLove restored the bugfix/parseFileLinesForLegacyDevices branch November 5, 2023 10:14
@TranceLove TranceLove deleted the bugfix/parseFileLinesForLegacyDevices branch November 5, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Related unexpected behavior or something worth investigating.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants