Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kotlin to 1.9.10 #3955

Closed

Conversation

TranceLove
Copy link
Collaborator

Description

As title; with some deprecation at build.gradle removed.

Also fixes code problem at BaseBottomSheetFragment causing project compile fails - where a when branch for SYSTEM theme is missing.

There is no handling for SYSTEM theme at ThemedActivity, hence the do-nothing branch as BaseBottomSheetFragment too.

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Also fixes code problem at BaseBottomSheetFragment causing project compile fails - where a when branch for SYSTEM theme is missing.

There is no handling for SYSTEM theme at ThemedActivity, hence the do-nothing branch as BaseBottomSheetFragment too.
@TranceLove TranceLove added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Oct 15, 2023
@TranceLove
Copy link
Collaborator Author

Not target for 4.0 release, hence draft status.

Pending manual testing...

@TranceLove TranceLove closed this Jul 14, 2024
@TranceLove TranceLove deleted the feature/kotlin-1-9-10 branch July 14, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant