Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

마이페이지 이름 수정 불가 및 ui 수정 #34

Merged
merged 12 commits into from
Sep 1, 2023

Conversation

yonghanJu
Copy link
Contributor

@yonghanJu yonghanJu commented Aug 31, 2023

😎 작업 내용

  • 1차 배포 테스트 이후 변경사항들 적용

🧐 변경된 내용

  • 세로화면 고정
  • 생월 1개월 차이나는 버그 수정
  • 글쓰기 중복 버그 수정
  • 마이페이지 이름 수정 안되도록 수정
  • 내위치 마커 흰 테두리 적용
  • 달리기 정보 보여주는 텍스트 색상 적용
  • 달릴 때 초 느린 버그 수정

🥳 동작 화면

image image

🤯 이슈 번호

🥲 비고

  • 비고 없음

@yonghanJu yonghanJu self-assigned this Aug 31, 2023
Copy link
Member

@soopeach soopeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

Comment on lines +100 to +101
modifier = Modifier.padding(bottom = 12.dp).weight(1f).height(40.dp)
.clip(RoundedCornerShape(12.dp)).background(WalkieColor.GrayDefault),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 Ktlint에서 이렇게 잡아주나요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체이닝 했을 때 하나하나 개행을 해주지 않았던 것 같아요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ktlint가 그래요???
체이닝했을 때 개행하는게 가독성이 훨씬 좋지 않나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 줄 길이를 넘지 않으면 따로 개행해주지는 않아서 직접 개행해야 하네요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 몰랐네ㅜㅜ

)
}
}
}
}
}

enum class TEXTVISIBLESTATE {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum class 클래스명 일반 클래스명과 컨벤션이 동일하지 않나요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요 수정하도록 하겠습니다

Comment on lines 50 to 51
val name = viewModel.name.collectAsStateWithLifecycle(initialValue = "")
val nick = viewModel.nick.collectAsStateWithLifecycle(initialValue = "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 String 확장 프로퍼티로 만들어놔도 좋을 것 같아요!
지금 도메인에 혹시 없나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// before
val name = viewModel.name.collectAsStateWithLifecycle(initialValue = "")

// after
val name = viewModel.name.확장함수()

위 형태가 될 텐데 collectAsStateWithLifecycle 함수 이름이 좀 길긴해도
함수 하나를 굳이 다른 함수로 만들 필요는 없지 않을까 생각했어요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-01 at 3 21 50 PM
  • 이렇게 만들어서
Screenshot 2023-09-01 at 3 22 29 PM
  • 이렇게 쓰자는 말이었어요!

Copy link
Contributor Author

@yonghanJu yonghanJu Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 좋습니다! 도메인에 만들어서 사용도록 변경했습니다

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당!

val name = viewModel.name.collectAsStateWithLifecycle(initialValue = "")
val nick = viewModel.nick.collectAsStateWithLifecycle(initialValue = "")

EditProfileContent(name = name.value ?: "null", nick = nick.value ?: "null") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘도 공백 확장 프로퍼티 쓰면 더 좋을 것 같아요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공백확장 프로퍼티 사용이 좋겠네요

@@ -156,9 +162,12 @@ fun EditProfileContent(name: String, nick: String, onCloseClicked: () -> Unit) {

Spacer(modifier = Modifier.height(16.dp))

// TODO 임시로 만든 변수, viewModel, uiState로 관리하도록 변경 필요(139, 171 line)
var nickCheckState: Boolean? by rememberSaveable { mutableStateOf(null) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘 왜 널러블인가요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기본 상태가 3가지 상태를 가져야하는데 enum 클래스로 정의하지 않고 그냥 널러블 boolean 을 사용했는데 좋지 않아보이네요

기본(체크 이전) -> null
체크 성공 -> true
체크 실패 -> false

이렇게 3가지 상태를 표현합니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그 예전에 말씀하셨던 nullable Boolean 이네요 ㅋㅋㅋㅋㅋㅋㅋ
간단한 enum class 하나 만들까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아요 세상에서 제일 쓸모없는게 nullable Boolean 같았지만 야매코드 쓰다보니깐 생각없이 쓰게 되네요..ㅋㅋㅋ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 하지만 그 맘 이해갑니다

@@ -136,7 +136,7 @@ fun SignInUserNameScreen(onSuccess: () -> Unit) {
viewModel.setUserNameState(
userNameState.copy(
year = year,
month = month,
month = month + 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 라이브러리 자체 문제인가요???ㅋㅋㅋ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

월일 표현 방식이 1부터 시작하는 라이브러리들도 있고 0부터 시작하는 라이브러리들도 있는데 타임피커에서 월을 0부터 시작하네요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 그렇군요..!!

@yonghanJu
Copy link
Contributor Author

@soopeach 오랜만에 코드 종합적으로 건설적인 리뷰를 받으니 너무 좋았습니다 감사합니다~

@soopeach
Copy link
Member

soopeach commented Sep 1, 2023

@soopeach 오랜만에 코드 종합적으로 건설적인 리뷰를 받으니 너무 좋았습니다 감사합니다~

아좌좌 화이팅!! 용한님 덕분에 저도 힘이나요

@yonghanJu yonghanJu merged commit 9524070 into compose/develop Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants